On Fri, Sep 16, 2011 at 09:56:55AM +0200, Felix Fietkau wrote: > On 2011-09-02 10:21 AM, Rajkumar Manoharan wrote: > >The assumption is that during the hw config, transmission was > >already stopped by mac80211. Sometimes the AP can be switching > >b/w the ht modes due to intolerant or etc where STA is in > >the middle of transmission. In such scenario, buffer overflow > >was observed at driver side. And also before updating the rate > >control, the frames are continued to xmited with older rates. > >This patch ensures that the frames are always xmitted with > >updated rates and avoid buffer overflow. > > > >Signed-off-by: Rajkumar Manoharan<rmanohar@xxxxxxxxxxxxxxxx> > John, please revert this one, it's completely messed up. It stops > queues, and calls drv_flush whenever it receives a beacon with > 802.11n information, even if 802.11n is already enabled and the mode > is the correct one. > Additionally, it even wakes the queues again before the settings > have been applied, so it's 100% useless. As we discussed in irc, drv_flush & queue stop shouldn't be called so frequently. It is a bug. But this patch prevents the transmission while doing hw config because of 20/40 switch from beacon ie. So this patch is really needed and also there is not point in covering bss_info_change state. To avoid the accidential queue wakeup by flush, this patch defines new reason code. I will send the followup patch ASAP. -- Rajkumar -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
