Search Linux Wireless

Re: [PATCH 08/27] iwlagn: beautify the code - remove uneeded line break

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2011-09-15 at 12:37 -0700, Joe Perches wrote:
> On Thu, 2011-09-15 at 11:46 -0700, Wey-Yi Guy wrote:
> > From: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
> > Two lines could be concatenated without exceeding the 80 char limit.
> > diff --git a/drivers/net/wireless/iwlwifi/iwl-trans.c b/drivers/net/wireless/iwlwifi/iwl-trans.c
> []
> > @@ -308,10 +308,8 @@ static int iwl_trans_txq_alloc(struct iwl_trans *trans,
> >  
> >  	txq->q.n_window = slots_num;
> >  
> > -	txq->meta = kzalloc(sizeof(txq->meta[0]) * slots_num,
> > -			    GFP_KERNEL);
> > -	txq->cmd = kzalloc(sizeof(txq->cmd[0]) * slots_num,
> > -			   GFP_KERNEL);
> > +	txq->meta = kzalloc(sizeof(txq->meta[0]) * slots_num, GFP_KERNEL);
> > +	txq->cmd = kzalloc(sizeof(txq->cmd[0]) * slots_num, GFP_KERNEL);
> 
> kcalloc would be even prettier...
> 
> 
agree, would you mind submit a patch to changes it

Thanks
Wey


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux