On Wed, Sep 14, 2011 at 10:24:27PM +0530, Rajkumar Manoharan wrote: > On Wed, Sep 14, 2011 at 02:33:22PM +0530, Rajkumar Manoharan wrote: > > On Wed, Sep 14, 2011 at 11:45:20AM +0300, Kalle Valo wrote: > > > Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxxxx> writes: > > > > > > > On Tue, Sep 13, 2011 at 01:32:26PM -0400, John W. Linville wrote: > > > >> On Tue, Sep 06, 2011 at 08:18:50PM +0530, Rajkumar Manoharan wrote: > > > >> > Do the magnitude/phase coeff correction only if the outlier > > > >> > is detected. > > > >> > > > > >> > Cc: stable@xxxxxxxxxx > > > >> > Signed-off-by: Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxxxx> > > > >> > --- > > > >> > > > > >> > static void ar9003_hw_tx_iqcal_load_avg_2_passes(struct ath_hw *ah, > > > >> > > > >> What is the effect of the bug being fixed here? Is this fix intended for 3.1? > > > > > > > > The first entry of phase/mag got changed to average if outlier is > > > > not detected. This patch ensures to update appropriate index of > > > > magnitude/phase. This patch is applicable from 3.0 onwards. > > > > > > Sorry, but this doesn't tell much. What's the user visible change > > > with this patch? Better sensitivity, less transmission errors or what? > > > > > It has minor impact because of this bug, an undesirable Tx IQ correction value > > will be assigned to Tx gain settings wheen outlier is not happened. The impacts > > on overall system throughput should be very minor. > > > John, > > Not doing the calibrations in proper manner could impact performance in congested > network. Maybe i should update the impact in the commit log. Wanna send me v2 > patch? Please. -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html