On Wed, 2011-09-14 at 12:44 +0300, Arik Nemtsov wrote: > On Thu, Aug 25, 2011 at 13:05, Kalle Valo <kvalo@xxxxxxxxxx> wrote: > > Arik Nemtsov <arik@xxxxxxxxxx> writes: > > > >> + if (!wl1271_is_active_sta(wl, hlid)) { > >> + WARN_ON(1); > >> + return; > >> + } > > > > I think this is neater: > > > > if (WARN_ON(!wl1271_is_active_sta(wl, hlid)) > > return; > > (Sorry for the late response) > > It does look nicer. Luca - do you mind changing it before merging? Done, and thanks for giving me more work to do! Oh, well, I deserved it. :P -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html