Search Linux Wireless

[FYI] iwlagn: fix command queue timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



And here's another one -- I think iwlegacy has the same bug which
probably means I can answer my question below with yes, it definitely
does need to go to stable ...



From: Johannes Berg <johannes.berg@xxxxxxxxx>

If the command queue is constantly busy,
which can happen in P2P, the hangcheck
timer will frequently find a command in
it and will eventually reset the device
because nothing sets the timestamp for
this queue when commands are processed.

Fix this by setting the timestamp when
a command completes.

Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
---
It's possible this needs to go to stable?

 drivers/net/wireless/iwlwifi/iwl-trans-pcie-tx.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/net/wireless/iwlwifi/iwl-trans-pcie-tx.c	2011-09-09 13:55:03.000000000 +0200
+++ b/drivers/net/wireless/iwlwifi/iwl-trans-pcie-tx.c	2011-09-09 13:55:26.000000000 +0200
@@ -928,6 +928,8 @@ void iwl_tx_cmd_complete(struct iwl_tran
 	cmd = txq->cmd[cmd_index];
 	meta = &txq->meta[cmd_index];
 
+	txq->time_stamp = jiffies;
+
 	iwlagn_unmap_tfd(trans, meta, &txq->tfds[index],
 			 DMA_BIDIRECTIONAL);
 


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux