On Thu, 2011-09-08 at 09:17 -0700, Javier Cardona wrote: > On Thu, Sep 8, 2011 at 12:01 AM, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Wed, 2011-09-07 at 17:49 -0700, Javier Cardona wrote: > > > >> + /* For mesh, the use of the QoS header is mandatory */ > >> + if (ieee80211_vif_is_mesh(&sdata->vif)) > >> + sta_flags |= WLAN_STA_WME; > >> + > > > > With patch 3, this piece seems unnecessary? > > At that point we don't know who the next hop peer will so the previous > block (below) will not find an sta. Also, we want the QoS header in > multicast frames. So I thought this might be the least intrusive way. > > >>> > if (!is_multicast_ether_addr(hdr.addr1)) { > rcu_read_lock(); > sta = sta_info_get(sdata, hdr.addr1); > if (sta) > sta_flags = get_sta_flags(sta); > rcu_read_unlock(); > } > >>> Ok, yeah, that makes sense. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html