On Thu, Sep 8, 2011 at 11:08 AM, Felix Fietkau <nbd@xxxxxxxxxxx> wrote: > On 2011-09-08 10:58 AM, Helmut Schaa wrote: >> >> This is already done by rt2x00 and ath9k by checking the >> IEEE80211_TX_CTL_RATE_CTRL_PROBE flag. Instead we can simply do it in >> minstrel_ht. >> >> Signed-off-by: Helmut Schaa<helmut.schaa@xxxxxxxxxxxxxx> >> --- >> >> Felix, I didn't have a closer look at the ath9k aggregation code but I >> guess it >> can also be simplified with this change. >> >> Any objections? > > Yes, this probably breaks ath9k. IEEE80211_TX_CTL_AMPDU is used to indicate > that the packet is part of an aggregation session, so ath9k only does block > ack window tracking for packets that have this flag set. > I think the drivers should continue to check for > IEEE80211_TX_CTL_RATE_CTRL_PROBE Ok, the flag description is a bit misleading then: @IEEE80211_TX_CTL_AMPDU: this frame should be sent as part of an A-MPDU John, please drop this series. Helmut -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
