On Wed, Sep 7, 2011 at 11:14 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Wed, 2011-09-07 at 20:08 +0200, Johannes Berg wrote: >> On Tue, 2011-09-06 at 15:26 -0700, Javier Cardona wrote: >> > Mesh frames are required to have QoS headers to indicate the presence of a Mesh >> > Control Header in the payload. These patches add QoS headers to mesh frames, >> > but note that they don't implement full QoS support: mesh stations don't >> > currently advertise QoS capabilities. >> >> Uh, so does mesh want full QoS support or just QoS headers? The latter >> seems a little odd to me. But if it wants QoS how about zd1211rw? I >> don't think that even supports QoS? >> >> That's one thing that bothers me a little bit about this patchset -- >> previously, QoS frames could only happen when the device actually >> supported 4 queues, now this rule seems to be broken. I don't expect >> this to be a major issue, but it certainly is unexpected and will >> probably be forgotten by a lot of people in the future ... > > So after looking at this again -- what I'd much rather see instead of > the second patch, and what will also require fewer changes, is *only* > doing the change to ieee80211_set_qos_hdr(). Then, if the peer is a QoS > station, we'll get the right header -- if it isn't then we can't really > mesh with it but we'll accept that for legacy reasons (for now). > > I'd rather not send QoS frames to mesh stations that don't advertise QoS > capability, and I'd also rather not have to worry about sending QoS > frames when we don't actually support it locally. OK. If QoS support is mandatory for mesh stations, then definitely that's the way to go. We'll have to investigate how to advertise QoS for mesh interfaces: this is currently not happening even though all the hardware we use for mesh supports it. Also, we've never attempted to maintain backward compatibility with earlier versions of the draft. Thanks! Javier -- Javier Cardona cozybit Inc. http://www.cozybit.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
