Hi Rajkumar, On Tue, Sep 6, 2011 at 7:50 AM, Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxxxx> wrote: > The commit "ath9k_hw: Fix Tx IQ Calibration hang issue in > AR9003 chips" did not consider more than one potential sample > while calculating magnitude/phase average if more than one > sample has the same value which could affect post-processing > of outlier detection that causes an undesirable Tx IQ > correction value will be assigned to tx gain settings where > outlier happens. > [...] > + /* > + * finding mean magnitude/phase if possible, otherwise > + * just use the last value as the mean > + */ > + if (mp_count) > + mp_avg /= mp_count; > + else > + mp_avg = mp_coeff[i - 1]; Why use "i - 1" here instead of "nmeasurement - 1"? Seems more error-prone for later changes and harder to understand. -- Paul -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
