Hello On Mon, Aug 29, 2011 at 04:00:33PM +0200, Stanislaw Gruszka wrote: > On Mon, Aug 29, 2011 at 08:33:39AM -0500, Greg Dietsche wrote: > > On 08/29/2011 07:20 AM, Stanislaw Gruszka wrote: > > >On Sun, Aug 28, 2011 at 08:26:16AM -0500, Greg Dietsche wrote: > > >>This message should be a debug message and not a warning. So > > >>change it from IWL_WARN to IWL_DEBUG_HT. > > >I'm currently doing massive iwlegacy driver cleanup. Would be easier > > >for me to apply these patches on top of my changes instead of rebase > > >my patches. I will queue these two patches and post them together with > > >my pending patches. > > > > > That sounds good to me. I have the 4065 card in my laptop and want > > to learn how it works. If you want someone to test your changes, I'm > > willing. > > > > I have six other patches that are trivial in nature for the iwlegacy > > driver. One of those also applies to the iwlagn driver, so seven > > patches in total. They remove some null checks that aren't necessary > > and also cleanup a few unused variables. There are two patches in > > the set that I'm not 100% sure about. They remove null checks and I > > haven't been able to prove to myself that they are correct. However, > > if they aren't correct, then there are some null checks in other > > places that need to be added.... > > > > Anyway, I can hold off on these until you've done your cleanup and > > see what still applies, > > That would be great. > > > or if you have a tree someplace, I'd be > > happy to rebase them for you. > > I do not have publicly available tree. I'll probably try to get > one on git.kernel.org. I will let you know. I requested for kernel.org account but admins there have much more troubles currently than adding new account :-/ I put patches here: http://people.redhat.com/sgruszka/iwlegacy_cleanup.tar.bz2 They are on top of wireless-testing tree. You can apply them by something like that: cd wireless-testing for i in `ls -X ~/iwlegacy_cleanup/*.patch` ; do git am $i ; done Series include your 2 patches. You can test this cleanup and apply your new changes on top. I'll not do any further cleanup for some time now, perhaps continue when I got public git tree. Thanks Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
