Search Linux Wireless

Re: [PATCH v2] mac80211: add ssid config to bss information in AP-mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 5, 2011 at 12:02, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
>>  struct ieee80211_bss_conf {
>>       const u8 *bssid;
>> @@ -280,6 +285,9 @@ struct ieee80211_bss_conf {
>>       bool arp_filter_enabled;
>>       bool qos;
>>       bool idle;
>> +     u8 ssid[IEEE80211_MAX_SSID_LEN];
>> +     size_t ssid_len;
>> +     bool hidden_ssid;
>
> I guess the reason you don't use the nl80211 enum here is that the
> device doesn't care since the beacon is built by hostapd/mac80211 and
> entirely transparent to the device?

exactly.

>
>> +static void ieee80211_config_ap_ssid(struct ieee80211_sub_if_data
>> *sdata,
>> +                                    struct beacon_parameters *params)
>
> Any particular reason for not just inlining the few code lines?

I figured ieee80211_config_beacon() was too long as it is.

>
>
> However, what's this used for? Didn't we discuss this before and decide
> that there's no clear way to implement probe response offloading given
> the possibility that WPS, P2P and similar protocols that use probe
> request/response handshaking could be in use?

The FW treats WPS, P2P probe-requests as special cases and passes them
to the host without replying. This works well and passes all required
tests.
As discussed on IRC, in the future we'll have to add feature flags for
these cards, to let hostapd know about the offloading.

Arik
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux