On Thu, Sep 1, 2011 at 11:01 AM, Felix Fietkau <nbd@xxxxxxxxxxx> wrote:
> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
> index 49b93c2..95bc459 100644
> --- a/drivers/net/wireless/ath/ath9k/xmit.c
> +++ b/drivers/net/wireless/ath/ath9k/xmit.c
> @@ -581,8 +581,10 @@ static void ath_tx_complete_aggr(struct ath_softc *sc, struct ath_txq *txq,
>
> rcu_read_unlock();
>
> - if (needreset)
> - ath_reset(sc, false);
> + if (needreset) {
> + sc->sc_flags |= SC_OP_HW_RESET;
> + ieee80211_queue_work(sc->hw, &sc->hw_reset_work);
> + }
> }
I see SC_OP_HW_RESET is set only here but not other callers that set
the reset work, why is that but not in other places?
I should also note that ieee80211_queue_work() may just return and not
queue the work in the suspend case where there is a bug in mac80211 or
the driver; in that case SC_OP_HW_RESET would not be cleared but I
suspect upon resume we will clear it anyway.
If the goal is to check if the work is pending how about adding
ieee80211_work_pending() which uses work_pending() ?
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
