On 08/30/2011 06:00 PM, Vasanthakumar Thiagarajan wrote: > On Tue, Aug 30, 2011 at 04:44:50PM +0300, Kalle Valo wrote: > >> +int ath6kl_diag_write(struct ath6kl *ar, u32 address, void *data, u32 length) >> +{ >> + u32 count, *buf = data; >> + int ret; >> + >> + if (WARN_ON(length % 4)) >> + return -EINVAL; >> + >> + for (count = 0; count < length / 4; count++, address += 4) { >> + ret = ath6kl_diag_write32(ar, address, buf[count]); >> + if (ret) >> + return ret; >> } >> >> - return status; >> + return ret; > > drivers/net/wireless/ath/ath6kl/main.c: In function ‘ath6kl_diag_write’: > drivers/net/wireless/ath/ath6kl/main.c:297: warning: ‘ret’ may be > used uninitialized in this function Strange, my compiler didn't warn about this. Fixed in v2. Thanks, Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html