On Tue, Aug 30, 2011 at 12:26:10PM +0300, Kalle Valo wrote:
> On 08/29/2011 03:23 PM, Jouni Malinen wrote:
> > --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
> > +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> > @@ -776,6 +776,15 @@ static int ath6kl_cfg80211_scan(struct wiphy *wiphy, struct net_device *ndev,
> > + if (request->ie) {
> > + if (ath6kl_wmi_set_appie_cmd(ar->wmi, WMI_FRAME_PROBE_REQ,
> > + request->ie, request->ie_len)) {
> > + ath6kl_err("failed to set Probe Request appie for "
> > + "scan");
> > + return -EIO;
> > + }
> > + }
>
> I would prefer to return the original error code from the wmi call.
I followed the style used in this function with
ath6kl_wmi_startscan_cmd(), but sure, returning the error code from
wmi.c sounds reasonable.
--
Jouni Malinen PGP id EFC895FA
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
