On Tue, Aug 30, 2011 at 12:23:04PM +0300, Kalle Valo wrote: > On 08/29/2011 03:23 PM, Jouni Malinen wrote: > > +static int ath6kl_mgmt_tx(struct wiphy *wiphy, struct net_device *dev, > > + id = ar->send_action_id++; > > + if (id == 0) > > + id = ar->send_action_id++; > > + *cookie = id; > > + return ath6kl_wmi_send_action_cmd(ar->wmi, id, chan->center_freq, wait, > > + buf, len); > I don't understand the "if (id == 0)" check. It would be nice to get a > comment giving some background info about the situation. 0 is a reserved value in the target implementation and shall not be used in the WMI command. I'll add a comment on this. -- Jouni Malinen PGP id EFC895FA -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html