Search Linux Wireless

Re: [PATCH 11/20] ath6kl: Support channel set request for startscan command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/30/2011 01:04 PM, Raja Mani wrote:
> On Monday 29 August 2011 05:53 PM, Jouni Malinen wrote:
>
>>   	if (ath6kl_wmi_startscan_cmd(ar->wmi, WMI_LONG_SCAN, 0,
>> -				     false, 0, 0, 0, NULL) != 0) {
>> +				     false, 0, 0, n_channels, channels) != 0) {
>>   		ath6kl_err("wmi_startscan_cmd failed\n");
> 
> kfree(channels) for failure cases ??

It's freed below as there's no return call for the error case:

>>   		ret = -EIO;
>>   	}
>>
>>   	ar->scan_req = request;
>>
>> +	kfree(channels);          <-----
>> +
>>   	return ret;
>>   }

I also got fooled by this :)

Kalle
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux