On 2011-08-27 9:09 AM, Rajkumar Manoharan wrote:
On Sat, Aug 27, 2011 at 09:04:36AM +0200, Felix Fietkau wrote:
On 2011-08-27 8:52 AM, Rajkumar Manoharan wrote:
>On Sat, Aug 27, 2011 at 08:27:07AM +0200, Felix Fietkau wrote:
>> On 2011-08-27 7:52 AM, Rajkumar Manoharan wrote:
>> >Initialize 9us slot time as that is what is used mostly
>> >(for non-ERP cases) and also to be in sync with initvals.
>> >
>> >Signed-off-by: Rajkumar Manoharan<rmanohar@xxxxxxxxxxxxxxxx>
>> Why does it matter, mac80211 tells the driver to reconfigure it
>> anyway. Also, why use the stupid ATH9K_SLOT_TIME_* enums? I think we
>> should simply remove those.
>>
>In most of the case, mac80211 set as 9us and also initval uses 9us.
>The what is the problem of setting 9us as default. If you want to
>remove ATH9K_SLOT_TIME_* enums, ath9k should not set slottime till
>it got configured.
I don't see a problem with the change aside from the fact that it
should not make any difference at all, so I don't really see any
point to it.
I doubt that using long slottime might affect random backoff. so let it
to be in sync with initval till it is altered. am i right?
If you want to get this change in, I don't care. I'm just saying it
doesn't get left at the default long enough for it to matter in any way.
- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
