Search Linux Wireless

RE: [PATCH] mwifiex: replace kmalloc & memcpy sequences with kmemdup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Joe,

Thanks for your comment.

> Subject: Re: [PATCH] mwifiex: replace kmalloc & memcpy sequences with kmemdup
> 
> On Wed, 2011-08-24 at 20:52 -0700, Bing Zhao wrote:
> > Sequences of kmalloc/kzalloc and memcpy are replaced with
> > kmemdups.
> > diff --git a/drivers/net/wireless/mwifiex/join.c b/drivers/net/wireless/mwifiex/join.c
> []
> > -	tmp = kmalloc(rate1_size, GFP_KERNEL);
> > +	tmp = kmemdup(rate1, rate1_size, GFP_KERNEL);
> >  	if (!tmp) {
> > -		dev_err(priv->adapter->dev, "failed to alloc tmp buf\n");
> > +		dev_err(priv->adapter->dev, "failed to duplicate rate buf\n");
> 
> I wouldn't modify any OOM message.
> These _are_ allocs failures.

V2 patch has been sent.

Thanks,
Bing

> 
> [all the others removed]

��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux