Search Linux Wireless

Re: [PATCH V2 3/3] ath6kl: Add debugfs file entry to dump credit distribution stats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Vasanthakumar Thiagarajan <vthiagar@xxxxxxxxxxxxxxxx> writes:

> On Thu, Aug 25, 2011 at 01:26:37AM -0700, Joe Perches wrote:
>> On Thu, 2011-08-25 at 13:00 +0530, Vasanthakumar Thiagarajan wrote:
>> > +	struct ath6kl *ar = file->private_data;
>> > +	struct htc_target *target = ar->htc_target;
>> > +	struct htc_endpoint_credit_dist *ep_list;
>> > +	char *buf;
>> > +	unsigned int buf_len = 128, len = 0;
>> > +	ssize_t ret_cnt;
>> > +
>> > +	buf_len += get_queue_depth(&target->cred_dist_list) * 128;
>> 
>> Doesn't look like 128 is the right size.
>
> It is well enough, needed is only around 110 bytes.

Proper defines for the values would be nice. Magic numbers are always
tricky.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux