On Wed, 2011-08-24 at 19:23 -0700, Greg KH wrote: > On Wed, Aug 24, 2011 at 05:42:11PM -0700, Henry Ptasinski wrote: > > On Wed, Aug 24, 2011 at 04:54:28PM -0700, Joe Perches wrote: > > > On Wed, 2011-08-24 at 16:17 -0700, Henry Ptasinski wrote: > > > > Augh. I included the wrong link. Correct link: > > > > http://linuxwireless.org/en/users/Drivers/brcm80211?action=AttachFile&do=get&target=0001-wireless-testing-add-brcm80211-v2.patch > > > > > > Can't you post the patch with git format-patch -M instead? > > > > This patch drops in a new copy of all the files, as there's been significant > > change since the last time staging-next and wireless-testing were in sync. > > (Deleting the existing files from staging will be a separate step.) > > > > I can generate a two-patch series instead: one to catch up wireless-testing > > with all the changes that have been applied to the brcm80211 drivers in > > staging, and then a second patch with a 'git mv' plus necessary > > Kconfig/Makefile changes. The first patch would still be quite large, but I'm > > ok with either approach. > Don't worry about that now, the real thing is a review of the code. A 2.8MB patch is _way_ too large to review. The reviewing should take place of posted patches to staging, not wireless-testing. And I believe that's not an RFC patch, but the actual patch to be applied. If so, I think that the right way to do that is not copy but a merge. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
