On Monday 22 August 2011 10:59 AM, Vasanthakumar Thiagarajan wrote:
On Sun, Aug 21, 2011 at 09:24:45PM +0530, Mohammed Shafi Shajakhan wrote:From: Mohammed Shafi Shajakhan<mohammed@xxxxxxxxxxxxxxxx> still there are few other memory leaks which will be fixed very soon Cc: Rajkumar Manoharan<rmanohar@xxxxxxxxxxxxxxxx> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@xxxxxxxxxxxxxxxx> Signed-off-by: Larry Finger<Larry.Finger@xxxxxxxxxxxx> --- drivers/net/wireless/ath/ath9k/htc_hst.c | 13 ++++++++----- drivers/net/wireless/ath/ath9k/wmi.c | 3 ++- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c b/drivers/net/wireless/ath/ath9k/htc_hst.c index 1b90ed8..e435c9b 100644 --- a/drivers/net/wireless/ath/ath9k/htc_hst.c +++ b/drivers/net/wireless/ath/ath9k/htc_hst.c @@ -169,13 +169,14 @@ static int htc_config_pipe_credits(struct htc_target *target) time_left = wait_for_completion_timeout(&target->cmd_wait, HZ); if (!time_left) { dev_err(target->dev, "HTC credit config timeout\n"); - return -ETIMEDOUT; + ret = -ETIMEDOUT; + goto err;Are you sure we have to free the skb upon timeout?. It looks like it is already taken care in ath9k_htc_txcompletion_cb(). The same may apply to your other changes as well.
Vasanth thanks for your review, I haven't and not aware of that code flow/callback. I will check into that.
thanks, shafi
Vasanth
-- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
