Search Linux Wireless

Re: [PATCHv2 01/14] staging: brcm80211: use wait queues instead of semaphores in wl_cfg80211.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 12, 2011 at 09:09:31PM +0200, Arend van Spriel wrote:
> 
> Or have people vote which version they prefer. I prefer v2.
> 

It doesn't really matter either way, but I prefer the original one.

Checkpatch.pl only cares about if statements.  This is fairly
idiomatic C.  After all we wouldn't write a while statement like:

	foo = some_func();
	while (foo) {
		frob();
		frob();
		foo = some_func();
	}

We'd just write:
	while ((foo = some_func())) {
		frob();
		frob();
	}

And do while() feels the same to me.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux