On Mon, 2011-08-15 at 07:21 -0700, Stanislaw Gruszka wrote: > On Mon, Aug 15, 2011 at 06:13:39AM -0700, Guy, Wey-Yi wrote: > > now we are working on separate iwlagn driver into two layers (upper and > > lower), the lower layer contains both bus and transport sub-layer which > > is hw dependent, and the upper layer should be bus/hw independent. by > > doing so, the single driver can handle different bus and different core > > architecture. Having the share data structure (priv->shrd->foo) between > > two layers is for that reason (loosely couple). > > You did not explained reason for introducing iwl_shared structure, > actually you confirmed it is useless. You should simply share iwl_priv > on any layer you have. > > Stanislaw It is not true, I mean "boring" but not "useless", it does not make sense share all the priv with lower layer. think about I also mention different core architecture, that mean we can have different upper layer which has different priv; but shrd is always common to all different upper layer to share with lower layer. Wey -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
