On Fri, Aug 12, 2011 at 5:28 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Thu, 2011-08-11 at 19:53 -0700, Thomas Pedersen wrote:
>
>> +#ifdef CONFIG_MAC80211_VERBOSE_MPATH_DEBUG
>> +static inline void mpath_dbg(const char *fmt, ...)
>> +{
>> + struct va_format vaf;
>> + va_list args;
>> +
>> + va_start(args, fmt);
>> +
>> + vaf.fmt = fmt;
>> + vaf.va = &args;
>> +
>> + printk(KERN_DEBUG "%pV", &vaf);
>> + va_end(args);
>> + return;
>> +}
>> +#else
>> +static inline void mpath_dbg(const char *fmt, ...)
>> +{
>> + return;
>> +}
>> +#endif
>
> Oh, maybe that's too complicated after all... How about
>
> #ifdef ...
> #define ...
> #else
> static inline void mpath_dbg(const char *fmt, ...)
> __attribute__ ((format (printf, 1, 2)))
> {
> }
> #endif
>
> Definitely want the format attribute, that was my whole point :)
Oh I see. Looking at it again, my function above doesn't even have any
argument checking :P. Didn't know about that __attribute__ etiher,
thanks!
> Bah, maybe it all doesn't matter, in which case maybe the first version
> is better.
Sure, let's go with the first one.
>
> johannes
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
