On Tue, 2011-08-09 at 12:13 +0300, Eliad Peller wrote:
> Sometimes the fw doesn't send the DISCONNECT_EVENT_COMPLETE_ID
> on station role stop, so don't wait for it.
Why? A bug? Or any good reason for it?
> diff --git a/drivers/net/wireless/wl12xx/cmd.c b/drivers/net/wireless/wl12xx/cmd.c
> index 9ef8621..ad926d2 100644
> --- a/drivers/net/wireless/wl12xx/cmd.c
> +++ b/drivers/net/wireless/wl12xx/cmd.c
> @@ -640,18 +640,12 @@ int wl1271_cmd_role_stop_sta(struct wl1271 *wl)
> ret = wl1271_cmd_send(wl, CMD_ROLE_STOP, cmd, sizeof(*cmd), 0);
> if (ret < 0) {
> wl1271_error("failed to initiate cmd role stop");
> goto out_free;
> }
>
> - ret = wl1271_cmd_wait_for_event(wl, DISCONNECT_EVENT_COMPLETE_ID);
> - if (ret < 0) {
> - wl1271_error("cmd role stop sta event completion error");
> - goto out_free;
> - }
> -
Can't this cause possible race conditions in the firmware if, for
instance, we stop and start the sta role quickly?
--
Cheers,
Luca.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
