On Wed, 2011-08-10 at 13:24 +0300, Eliad Peller wrote: > On Wed, Aug 10, 2011 at 12:19 PM, Luciano Coelho <coelho@xxxxxx> wrote: > > On Tue, 2011-08-09 at 12:13 +0300, Eliad Peller wrote: > >> +enum wl1271_cmd_lid_key_type { > >> + UNICAST_LID_TYPE = 0, > >> + BROADCAST_LID_TYPE = 1, > >> + WEP_DEFAULT_LID_TYPE = 2 > >> +}; > > > > Doesn't LID_TYPE_UNICAST, LID_TYPE_BROADCAST and so on look better? > > > it does, but i didn't touch this struct (it wasn't in the context diff > expected, so it looks like it was deleted and re-added), and i should > avoid adding more stuff (changing all the existing uses of this enum) > to this already-too-big patch. Right, right. I didn't realize that this was actually moved, not added here. -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html