On Tue, 2011-08-09 at 06:27 -0700, Ben Greear wrote: > On 08/09/2011 05:14 AM, Johannes Berg wrote: > > On Mon, 2011-07-25 at 10:18 -0700, Ben Greear wrote: > >> On 07/25/2011 08:29 AM, Eliad Peller wrote: > >>> The hw is currently not configured when going > >>> back on-channel. > >> > >> I am less sure about this patch. With the existing code, > >> I think it should catch going from on channel to off > >> and do the hw config properly. > >> > >> With your change it will also reconfig the hardware, but it will > >> reconfig even if we were already on-channel (if, for instance, > >> local->tmp_channel is oper-channel), right? > > > > I think even if we're already on the same channel, we might still have > > the off-channel flag (IEEE80211_CONF_OFFCHANNEL) set? So the patch might > > still be needed to clear that? > > Well, maybe so, but if we are not off-channel and still have the off-channel > flag set, that would seem to be another bug. Hm, true. Not sure about this then. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html