On Mon, Aug 08, 2011 at 06:07:07PM +0200, Gábor Stefanik wrote: > 2011/8/8 Rafał Miłecki <zajec5@xxxxxxxxx>: > > W dniu 8 sierpnia 2011 13:57 użytkownik Geert Uytterhoeven > > <geert@xxxxxxxxxxxxxx> napisał: > >> On Sat, Jul 23, 2011 at 02:12, Linux Kernel Mailing List > >> <linux-kernel@xxxxxxxxxxxxxxx> wrote: > >>> Gitweb: http://git.kernel.org/linus/1d738e64f3d957d56c1b51e64ebdef986a8760e3 > >>> Commit: 1d738e64f3d957d56c1b51e64ebdef986a8760e3 > >>> Parent: 0cd20a278e1ef9da9f6a987942794c9d65af8c4d > >>> Author: Rafał Miłecki <zajec5@xxxxxxxxx> > >>> AuthorDate: Thu Jul 7 15:25:27 2011 +0200 > >>> Committer: John W. Linville <linville@xxxxxxxxxxxxx> > >>> CommitDate: Fri Jul 8 11:11:25 2011 -0400 > >> > >>> diff --git a/drivers/net/wireless/b43/phy_lcn.h b/drivers/net/wireless/b43/phy_lcn.h > >>> new file mode 100644 > >>> index 0000000..c046c2a > >>> --- /dev/null > >>> +++ b/drivers/net/wireless/b43/phy_lcn.h > >> > >>> \ No newline at end of file > >> > >> Woops... > >> > >> gcc/cpp also complains: > >> > >> drivers/net/wireless/b43/phy_lcn.h:14:28: warning: no newline at end of file > > > > Sorry, I didn't know we want empty lines at the end. I also don't > > think it's mentioned in kernel's CodingStyle. > > I'm pretty sure it is basic Unix knowledge that all text files SHOULD > (RFC 2119) end with a newline character, unless otherwise noted > explicitly. In fact, many Unix text editors automatically insert a > newline at the end, and forbid you from deleting it. Please use an editor that does this appropriately, but do _not_ simply add an empty line at the end of a file. 'git am' complains about empty lines at the end of a file during a commit. I find that simple loading and saving such files with vi is sufficient for me -- YMMV. John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
