On Mon, 2011-05-23 at 14:34 -0700, Paul Stewart wrote:
> @@ -1014,6 +1014,8 @@ enum nl80211_commands {
> * @%NL80211_ATTR_REKEY_DATA: nested attribute containing the information
> * necessary for GTK rekeying in the device, see &enum nl80211_rekey_data.
> *
> + * @NL80211_ATTR_SCAN_FLAGS: scan request control flags (u8)
I think it should either be a u32 or a flag attribute. u8 is kinda
pointless for a flags attribute since it needs 4 bytes of space anyway.
> +++ b/include/net/cfg80211.h
> @@ -769,6 +769,15 @@ struct cfg80211_ssid {
> };
>
> /**
> + * enum cfg80211_scan_flag - scan request control flags
> + *
> + * @CFG80211_SCAN__FLAG_TX_ABORT: abort scan on pending transmit
> + */
> +enum cfg80211_scan_flags {
> + CFG80211_SCAN_FLAG_TX_ABORT = BIT(0),
> +};
Err, this needs to be in nl80211.h as well, no? How else would userspace
know what flags it can use?
Additionally, it would seem that there's a need to advertise what flags
are supported by a given driver.
Would you mind splitting into nl80211/mac80211 pieces?
Also -- maybe you should explain a bit more verbosely in the commit log
why this is a good idea? I'm not even sure how it really reduces TX
latency?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
