Search Linux Wireless

RE: [PATCH] mwifiex: remove redundant variable scan_table_idx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi John,

> -----Original Message-----
> From: Bing Zhao [mailto:bzhao@xxxxxxxxxxx]
> Sent: Thursday, July 21, 2011 8:26 PM
> To: linux-wireless@xxxxxxxxxxxxxxx
> Cc: John W. Linville; Amitkumar Karwar; Kiran Divekar; Yogesh Powar; Frank Huang; Bing Zhao
> Subject: [PATCH] mwifiex: remove redundant variable scan_table_idx
> 
> mwifiex_get_bss_info() routine updates variable 'info->scan_table_idx'
> but it is never used.

Could you please take this patch if it looks OK?

Thanks,
Bing

> 
> Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx>
> Signed-off-by: Bing Zhao <bzhao@xxxxxxxxxxx>
> ---
>  drivers/net/wireless/mwifiex/ioctl.h     |    1 -
>  drivers/net/wireless/mwifiex/sta_ioctl.c |   12 ------------
>  2 files changed, 0 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/net/wireless/mwifiex/ioctl.h b/drivers/net/wireless/mwifiex/ioctl.h
> index bd9e074..e0b68e7 100644
> --- a/drivers/net/wireless/mwifiex/ioctl.h
> +++ b/drivers/net/wireless/mwifiex/ioctl.h
> @@ -134,7 +134,6 @@ struct mwifiex_ver_ext {
>  struct mwifiex_bss_info {
>  	u32 bss_mode;
>  	struct mwifiex_802_11_ssid ssid;
> -	u32 scan_table_idx;
>  	u32 bss_chan;
>  	u32 region_code;
>  	u32 media_connected;
> diff --git a/drivers/net/wireless/mwifiex/sta_ioctl.c b/drivers/net/wireless/mwifiex/sta_ioctl.c
> index 10ef9e9..fd764b3 100644
> --- a/drivers/net/wireless/mwifiex/sta_ioctl.c
> +++ b/drivers/net/wireless/mwifiex/sta_ioctl.c
> @@ -376,7 +376,6 @@ int mwifiex_get_bss_info(struct mwifiex_private *priv,
>  {
>  	struct mwifiex_adapter *adapter = priv->adapter;
>  	struct mwifiex_bssdescriptor *bss_desc;
> -	s32 tbl_idx;
> 
>  	if (!info)
>  		return -1;
> @@ -394,17 +393,6 @@ int mwifiex_get_bss_info(struct mwifiex_private *priv,
> 
>  	info->region_code = adapter->region_code;
> 
> -	/* Scan table index if connected */
> -	info->scan_table_idx = 0;
> -	if (priv->media_connected) {
> -		tbl_idx =
> -			mwifiex_find_ssid_in_list(priv, &bss_desc->ssid,
> -						  bss_desc->mac_address,
> -						  priv->bss_mode);
> -		if (tbl_idx >= 0)
> -			info->scan_table_idx = tbl_idx;
> -	}
> -
>  	info->media_connected = priv->media_connected;
> 
>  	info->max_power_level = priv->max_tx_power_level;
> --
> 1.7.0.2

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux