On Tuesday 02 August 2011 23:32:27 Daniel Drake wrote: > On 2 August 2011 21:09, Vasily Khoruzhick <anarsoul@xxxxxxxxx> wrote: > > Because no one puts interface down before suspend? > > I just re-tested - if interface is up - kernel does not put it down > > before suspend, so I got a lot of timeouts and errors on dmesg after > > resume. > > I can't see how this would have been influenced by my work. Now generic libertas driver controls power, not if_spi. So it should be able to turn off card before going suspend. Messing with power in if_* and generic part does not look like a good idea to me. > Your resume handler should already be fixing up the hardware state so > that it can be operated (regardless of any power saving that might > come into effect), or otherwise your suspend handler should cause the > device to be removed so that it can be reprobed completely during > resume. My resume handler calls lbs_suspend to detach device, and it expects that lbs_suspend will disable card power. > Daniel Regards Vasily -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
