Search Linux Wireless

Re: [PATCH 2/2] b43: bcma: get DMA translation bits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/19/2011 04:05 AM, Rafał Miłecki wrote:

+#ifdef CONFIG_B43_BCMA
+	case B43_BUS_BCMA:
+		dma->translation = bcma_dma_translation(dev->dev->bdev->bus);
+		break;
+#endif

How about we set dma->translation to 0x40000000 for 32-bit DMA and to 0x80000000 for 64-bit DMA and remove shifting translation by 1 in the 64-bit DMA code? There should be a warning for non-PCI devices here. No ifdefs, no separate treatment of different buses.

I think we are adding too much complexity here.

--
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux