On Sun, 2011-07-17 at 12:36 -0500, Thomas Pedersen wrote: > >> > Also ... since you'll need PS support eventually anyway, maybe you > >> > should refactor "struct ieee80211_if_ap" into something AP-specific > >> > (currently only VLANs) and the rest, and then use "the rest" in mesh as > >> > well to make all this code more unified. > >> > >> I like this approach much better. Are you suggesting just factoring > >> out the PS data, or taking it further and creating a generic "if which > >> beacons"? > > > > Well, I don't think "iface which beacons" is really what we need here -- > > IBSS sends beacons as well but we don't really have PS support there and > > it'd be different anyway. But on the other hand, if you also factor out > > the beacon pointer, you can embed that into both. Like I said, I think > > from struct ..._if_ap you only have the vlan list that you don't want? > > I'd rather just factor all the PS data out for now, and maintain the > beacon separately. Is there Is there any good reason we'd want to lump > these two together? ieee80211_beacon_add_tim() for example already > treats these as separate. No that's fine, I see no particular reason to do one or the other. Or maybe actually I do -- beacon handling requires TX PS handling for the TIM IE? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
