On Thu, 2011-07-14 at 17:50 -0700, Thomas Pedersen wrote:
> The mesh specific beacon IEs go right before the vendor IEs. Add a
> filter that checks for custom IEs (currently just the RSN IE), which
> belong after the TIM, but before HT. Also, ensure we don't add any
> custom IEs twice in mesh_mgmt_ies_add().
>
> Signed-off-by: Thomas Pedersen <thomas@xxxxxxxxxxx>
> ---
>
> v2:
> Ensure room for custom IEs in transmitted beacon (Johannes).
> We'll be allocating twice as much space as needed for some IEs
> (in tail_len and again ie_len), but it shouldn't be a big deal.
Not that I like allocating twice as much, but I don't really care
either.
Maybe you should be doing the cleanups in mesh_mgmt_ies_add()
separately? I'm having a hard time following these changes.
> + noffset = ieee80211_ie_split_vendor(ifmsh->ie, ifmsh->ie_len,
> + offset);
> + if (noffset != offset) {
isn't offset always 0 here? So wouldn't it make more sense to put 0
explicitly?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
