On Wed, Jul 13, 2011 at 11:25 PM, Jouni Malinen <j@xxxxx> wrote: > On Wed, Jul 13, 2011 at 04:45:47PM -0700, Thomas Pedersen wrote: >> Even though we don't currently implement PS for mesh points, the >> standard asks us to include a TIM element in beacons. Include an empty >> element for now. > > Is it allowed to not support PS in this type of case? AP does not have > such option.. > You're right, it doesn't look like PS support is optional. The standard requires us to respect the PS states of peers. Support for this will require some work, but in the meantime, we can include a TIM element indicating no frames buffered here, as well as a Mesh Awake Window which never expires. Otherwise, until we implement proper PS, might it be better not to include the TIM IE at all? >> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c >> @@ -2269,6 +2270,14 @@ struct sk_buff *ieee80211_beacon_get_tim(struct ieee80211_hw *hw, >> + pos = skb_put(skb, 6); >> + *pos++ = WLAN_EID_TIM; >> + *pos++ = 4; >> + *pos++ = 0; /* DTIM count */ >> + *pos++ = 0; /* DTIM period */ > > The DTIM Period value 0 is reserved and does not really make much > sense.. Would it be better to set this to 1? That makes sense, thanks! > > -- > Jouni Malinen PGP id EFC895FA > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
