Search Linux Wireless

Re: [PATCH 01/24] ath6kl: add bmi.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/13/2011 03:19 PM, Joe Perches wrote:
> On Wed, 2011-07-13 at 10:08 +0300, Kalle Valo wrote:
>> On 07/13/2011 07:28 AM, Joe Perches wrote:
>>> This helps grepping the sources for a specific dmesg.
>>> 			ath6kl_err("Unable to decrement the command credit count register: %d\n",
>>> 				   ret);
>> I agree, that would improve readibility. The reason why the lines were
>> split is because of checkpatch warnings. I could unsplit them but then
>> someone else might start complaining about high number checkpatch
>> warnings about long lines. So I really don't know what to do with them.
> 
> Add this patch to checkpatch?
> I'll submit it to Andrew Morton later.

Awesome! I had no idea checkpatch supports this. Just tested this with
ath6kl and I don't get long line warnings with long log messages.

Thank you very much for this!

I see that Andrew already took your patch but anyway:

Tested-by: Kalle Valo <kvalo@xxxxxxxxxxxxxxxxx>

Kalle
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux