On 07/13/2011 07:29 AM, Joe Perches wrote:
> On Wed, 2011-07-13 at 04:33 +0300, Kalle Valo wrote:
>> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxxxx>
>> diff --git a/drivers/net/wireless/ath/ath6kl/core.h b/drivers/net/wireless/ath/ath6kl/core.h
> []
>> +/* Pkt log info */
>> +struct pkt_log {
>> + struct info {
>> + __le16 st;
>> + __le16 end;
>> + __le16 cur;
>> + } info[4096];
>> + __le16 last_idx;
>> +} __packed;
>
> pretty big struct.
Indeed.
>> +struct skb_hold_q {
>> + struct sk_buff *skb;
>> + bool is_amsdu;
>> + u16 seq_no;
>> +};
>
> Maybe all the structs could be inspected for alignment
> and possible packing appropriateness?
>
> struct sk_buff *skb;
> u16 seq_no;
> bool is_amsdu;
> ?
I added a task to the todo list:
http://wireless.kernel.org/en/users/Drivers/ath6kl/todo
Kalle
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
