On 2011-07-11 8:52 AM, Michał Mirosław wrote:
Also constify pointers used in frame parsers to verify assumptions.
Signed-off-by: Michał Mirosław<mirq-linux@xxxxxxxxxxxx>
---
drivers/net/wireless/p54/p54pci.c | 2 --
drivers/net/wireless/p54/txrx.c | 22 +++++++++++-----------
2 files changed, 11 insertions(+), 13 deletions(-)
diff --git a/drivers/net/wireless/p54/p54pci.c b/drivers/net/wireless/p54/p54pci.c
index 1b75317..4491d33 100644
--- a/drivers/net/wireless/p54/p54pci.c
+++ b/drivers/net/wireless/p54/p54pci.c
@@ -229,8 +229,6 @@ static void p54p_check_rx_ring(struct ieee80211_hw *dev, u32 *index,
desc->host_addr = cpu_to_le32(0);
} else {
skb_trim(skb, 0);
- pci_dma_sync_single_for_device(priv->pdev, dma_addr,
- priv->common.rx_mtu + 32, PCI_DMA_FROMDEVICE);
desc->len = cpu_to_le16(priv->common.rx_mtu + 32);
}
This part does not look correct to me - same issue as your ath9k change,
which I commented on earlier. I don't think this call to
dma_sync_single_for_device is useless
- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
