Search Linux Wireless

Re: [ath5k-devel] [PATCH 3/5] ath5k: Add missing breaks in switch/case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/10/2011 05:28 AM, Joe Perches wrote:
Signed-off-by: Joe Perches<joe@xxxxxxxxxxx>

Acked-by: Pavel Roskin <proski@xxxxxxx>

---
  drivers/net/wireless/ath/ath5k/desc.c |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/desc.c b/drivers/net/wireless/ath/ath5k/desc.c
index 62172d5..f82383b 100644
--- a/drivers/net/wireless/ath/ath5k/desc.c
+++ b/drivers/net/wireless/ath/ath5k/desc.c
@@ -107,10 +107,13 @@ ath5k_hw_setup_2word_tx_desc(struct ath5k_hw *ah, struct ath5k_desc *desc,
  		case AR5K_PKT_TYPE_BEACON:
  		case AR5K_PKT_TYPE_PROBE_RESP:
  			frame_type = AR5K_AR5210_TX_DESC_FRAME_TYPE_NO_DELAY;
+			break;
  		case AR5K_PKT_TYPE_PIFS:
  			frame_type = AR5K_AR5210_TX_DESC_FRAME_TYPE_PIFS;
+			break;
  		default:
  			frame_type = type;
+			break;
  		}

The intention here is to replace frame types from enum ath5k_pkt_type with their AR5210-specific counterparts. So the intention is definitely to have breaks here.

Unfortunately, AR5210 cards are extremely rare these days. I have one, but it only works with old motherboards. It would take me half a day to dust off that system, compile the kernel and check the patch. But I assume your patch is fine. At least it's very unlikely to break anything.

--
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux