Search Linux Wireless

Re: [PATCH 094/119] staging: brcm80211: removed last occurrences of bcmsdh/BCMSDH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/05/2011 11:59 AM, Dan Carpenter wrote:
On Wed, Jun 29, 2011 at 04:47:58PM -0700, Franky Lin wrote:
@@ -549,7 +549,9 @@ brcmf_sdioh_request_byte(struct sdioh_info *sd, uint rw, uint func,
  						    sdio_enable_func
  						    (gInstance->func[2]);
  						if (err_ret)
-							sd_err(("bcmsdh_sdmmc: enable F2 failed:%d",
+							sd_err(("request_byte: "
+								"enable F2 "
+								"failed:%d",
                                                                          ^^^
	Newline needed here.
  								err_ret));
  					} else {
  						/* Disable Function 2 */
@@ -557,7 +559,9 @@ brcmf_sdioh_request_byte(struct sdioh_info *sd, uint rw, uint func,
  						    sdio_disable_func
  						    (gInstance->func[2]);
  						if (err_ret)
-							sd_err(("bcmsdh_sdmmc: Disab F2 failed:%d",
+							sd_err(("request_byte: "
+								"Disab F2 "
+								"failed:%d",
                                                                          ^^^
	Same.


  								err_ret));
  					}
  					sdio_release_host(gInstance->func[2]);
regards,
dan carpenter

Hi Dan,

First of all, thanks for milling through this list of patches. As you can see the code before the patch was also missing the \n character. I looked in the brcmfmac code and there are several other sd_*() macros missing it. So I will fix all with a separate patch.

Gr. AvS

--
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux