2011/7/4 Kalle Valo <kvalo@xxxxxxxxxx>: > Nick Kossifidis <mickflemm@xxxxxxxxx> writes: > >> O.K. let's comment it out then and add some information that it's >> disabled by default on available HALs... > > Leaving dead code lying around is bad. Why not add a comment with some > pointers how to get the old code if someone wants to do that? For > example git commit id is a good reference and I'm sure it will work > even after 10 years. > OK but either we remove the whole thing (ath5k_hw_set_sleep_cloc also, it's not being called anywhere else) or go the other way and leave it there with a comment or a debugfs/modparam. I believe having it as a debugfs/modparam option is better, after all it worked so far for most cards, we didn't had any bug reports related to 32KHz operation (at least I don't remember any). -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
