On Wed, 2011-06-29 at 22:27 +0200, Johannes Berg wrote: > On Wed, 2011-06-29 at 22:13 +0200, Jesper Juhl wrote: > > If the 'driver_initiated' function argument to > > __cfg80211_stop_sched_scan() is not 0 then we'll return an > > uninitialized 'ret' from the function. > > 'err'. I also dislike the initialisation, can we just replace the > "return err;" at the end of the function with "return 0;" instead? Luckily we were never using the return value when passing driver_initiate =- false. And I agree with you, there's no use to return err at the end. Better to simply return 0. > Luca, should it maybe be return -ENOENT anyway in the !sched_scan_req > case? We could do that. I had just thought that stopping a scan that is not running would just be a NOP, but if you prefer to return an error in that case, I can do it. -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
