Hi Joe, > > The pr_<level> ones are nice and I wished we had them all back in the > > days, but the NFC ones actually could take the controller as argument > > and then us the dev_* versions of these commands. > > I do think that if there's a controller struct that's always > or mostly used with nfc_<level>, then it should be added and > passed to the functions arguments, maybe with NULL used where > necessary. > > > At this stage of the project it is a bit too early to tell I guess. > > > I think emitting __func__ rarely adds useful information. > > Depends on how you are using your debug statements. I find it really > > helpful since then you can keep the text detail to a minimum. > > I don't disagree that while debugging function names > and tracing function entries/exits are useful. > > Today, dynamic_debug can add __func__ to the output as > desired so I think that it's not really necessary > to add to any <foo>_dbg callsite. I did not know that. Then we might should go ahead and also cleanup the Bluetooth subsystem. We do use an implied "Bluetooth: " prefix when calling BT_INFO, but that can be easily changed to bt_info() as well since I do not care about that part. The Bluetooth subsystem has a Linux 2.4 legacy history and a lot of things can be done a lot nicer these days. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
