Search Linux Wireless

Re: [PATCH] mac80211: Skip tailroom reservation for full HW-crypto devices with race fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2011-06-28 at 17:58 +0530, Yogesh Ashok Powar wrote:
> Based on inputs from Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> from http://markmail.org/thread/t4acssvlgb5gamt2 and
> http://markmail.org/thread/mydlihrhvfvevuim
> 
> In xmit path, devices that do full hardware crypto (including
> MMIC and ICV) need no tailroom. For such devices, tailroom
> reservation can be skipped if all the keys are programmed into
> the hardware (i.e software crypto is not used for any of the
> keys) and none of the keys wants software to generate Michael
> MIC and IV.
> 
> v2: Added check for IV along with MMIC to avoid
> >WARNING: at net/mac80211/wep.c:101 ieee80211_wep_add_iv+0x56/0xf3()
> Reported-by: Fabio Rossi <rossi.f@xxxxxxxxx>
> Tested-by: Fabio Rossi <rossi.f@xxxxxxxxx>
> Signed-off-by: Mohammed Shafi Shajakhan <mshajakhan@xxxxxxxxxxx>
> Cc: Mohammed Shafi Shajakhan <mshajakhan@xxxxxxxxxxx>
> 
> v3: Fixing races to avoid
> >WARNING: at net/mac80211/wpa.c:397 ccmp_encrypt_skb+0xc4/0x1f0
> Reported-by: Andreas Hartmann <andihartmann@xxxxxxxxxxxxxxx>
> Tested-by: Andreas Hartmann <andihartmann@xxxxxxxxxxxxxxx>
> Signed-off-by: Yogesh Ashok Powar <yogeshp@xxxxxxxxxxx>

This changelog entry is kinda messed up.

> +	 * Solution has been explained at
> +	 * http://markmail.org/message/c3ykchyv6azzmdum

Nothing against markmail, but I prefer links that contain a message ID
so if the link ever goes dead, you can google for the message ID. Maybe
use
http://mid.gmane.org/1308590980.4322.19.camel@xxxxxxxxxxxxxxxxxxxxx

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux