Search Linux Wireless

Re: [PATCH -next] bcma: main.c needs to include <linux/slab.h>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/27/2011 10:24 AM, Alexey Dobriyan wrote:
2011/6/27 Rafał Miłecki<zajec5@xxxxxxxxx>:
2011/6/26 Geert Uytterhoeven<geert@xxxxxxxxxxxxxx>:
m68k allmodconfig:

drivers/bcma/main.c: In function ‘bcma_release_core_dev’:
drivers/bcma/main.c:68: error: implicit declaration of function ‘kfree’

We already include slab.h in:
host_pci.c
scan.c
sprom.c

Maybe we can just include this in bcma.h as a better solution?

It isn't better solution.
It results in situation where unnecessary inclusion will be done.
Maybe it's not the case now, but it will be in future.

I agree. kfree() is used in main.c, not in bcma.h. There is no need for all files that include bcma.h to include linux/slab.h, especially (but not only) because bcma.h is not a private header.

--
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux