Aggreed again :-)
Thanks,
Emmanuel
> -----Original Message-----
> From: Johannes Berg [mailto:johannes@xxxxxxxxxxxxxxxx]
> Sent: Monday, June 27, 2011 11:43 AM
> To: Guy, Wey-Yi W
> Cc: linville@xxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; Grumbach,
> Emmanuel
> Subject: Re: [PATCH 18/25] iwlagn: warn about nested SYNC commands
>
> On Mon, 2011-06-27 at 10:40 +0200, Johannes Berg wrote:
> > On Sat, 2011-06-18 at 08:34 -0700, Wey-Yi Guy wrote:
> > > From: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
> > >
> > > Since there is no protection around SYNC host command mechanism, at
> least WARN
> > > when collision happens between two SYNC host comamnds. I am not sure
> there is a
> > > real issue (beyond the HCMD_ACTIVE flag maintenance) with having two
> SYNC host
> > > commands at the same time, but at least now, we will know about it.
> >
> > Please drop this particular patch. We discussed this but then forgot
> > about it -- this patch only warns when collisions actually happen, but
> > we can use lockdep to warn when collisions _could_ happen as well.
>
> Oops, n/m, I see it's already in. Will submit a follow-up that puts
> better code in place instead.
>
> johannes
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
