Sorry for the late reply. After looking into this a bit I agree with you the patch should be reverted. On Fri, Jun 24, 2011 at 6:54 PM, Colin Guthrie <gmane@xxxxxxxxxxxxxx> wrote: > 'Twas brillig, and Keng-Yü Lin at 10/05/11 15:48 did gyre and gimble: >> On Tue, May 10, 2011 at 11:36 AM, Colin Guthrie <mageia@xxxxxxxxxxxxxx> wrote: >>> 'Twas brillig, and Matthew Garrett at 09/05/11 18:11 did gyre and gimble: >>>> On Mon, May 09, 2011 at 06:09:27PM +0100, Colin Guthrie wrote: >>>> >>>>> Just a quick (non-compile) followup from my last email... blacklisting >>>>> the dell-laptop module works around the issue, so I think the commit >>>>> previously mentioned is indeed the culprit (as it's the only recent >>>>> commit and does fiddle with the rfkill stuff). >>>>> >>>>> Not sure what the best track forward is, but it's certainly a >>>>> regression, so should probably be fixed or reverted until a more >>>>> complete fix is found. >>>> >>>> If you can confirm that with a build then I'll do that. >>> >>> ACK. Reverting that commit and unblacklisting the dell_laptop module >>> restores the previous, working functionality. I've flipped rfkill a few >>> times and it's always worked fine. > > Just wondering if there was any progress on this. I ACKed a regression > but it was not reverted.... I thought the standard practice was to > revert until a fuller fix was found. > > I appreciate some other users will not get their fix but I was still > under the impression that this was the policy? > > I don't see any relevant changes in the 2.6.39 kernel: > > http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.39.y.git;a=history;f=drivers/platform/x86/dell-laptop.c;h=de301aa8e5c3799620ff5a06372b5e1942c2dab2;hb=HEAD > > nor in Linus' 2.6 tree (which I presume is actually for 3.0 these days?): > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=history;f=drivers/platform/x86/dell-laptop.c;h=d3841de6a8cf199ec08b24bd85f50a0af0490d37;hb=HEAD > > >> May I have the model of your Dell laptop? > snip.... > > I supplied all this info before here: > http://thread.gmane.org/gmane.linux.kernel.wireless.general/68758 > > Anything else I can do to move this forward? > I am happy to form the revert patch if necessary. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
