On Sun, Jun 19, 2011 at 11:04:12PM +0300, Kalle Valo wrote: > Arik Nemtsov <arik@xxxxxxxxxx> writes: > > > Sometimes when reporting a MIC failure rx->key may be unset. This > > code path is hit when receiving a packet meant for a multicast > > address, and decryption is performed in HW. > > > > Fortunately, the failing key_idx is not used for anything up to > > (and including) usermode, so we allow ourselves to set a bogus one > > when a key cannot be retrieved. > > [...] > > > - mac80211_ev_michael_mic_failure(rx->sdata, rx->key->conf.keyidx, > > + mac80211_ev_michael_mic_failure(rx->sdata, > > + rx->key ? rx->key->conf.keyidx : -1, > > (void *) skb->data, NULL, GFP_ATOMIC); > > In special cases like this a comment in the code would be nice. Repost with a comment, as Kalle requested? -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
