Hi Johannes,
On Wed, Jun 22, 2011 at 4:34 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
>
>> + * @NFC_ATTR_TARGET_SENS_RES: extra information for NFC-A targets
>> + * @NFC_ATTR_TARGET_SEL_RES: extra information for NFC-A targets
>
> Those descriptions aren't very useful to me, but hopefully if I knew
> anything about NFC I'd understand :)
Yes. But I can change a little bit:
@NFC_ATTR_TARGET_SENS_RES: NFC-A targets extra information such as NFCID
@NFC_ATTR_TARGET_SEL_RES: NFC-A targets extra information (useful if
the target is not NFC-Forum compliant)
>> + dev->targets_generation++;
>> +
>> + kfree(dev->targets);
>> + dev->targets = kzalloc(n_targets * sizeof(struct nfc_target),
>> + GFP_ATOMIC);
>> + if (!dev->targets) {
>> + dev->n_targets = 0;
>> + spin_unlock_bh(&dev->targets_lock);
>> + return -ENOMEM;
>> + }
>> +
>> + memcpy(dev->targets, targets, n_targets * sizeof(struct nfc_target));
>> + dev->n_targets = n_targets;
>
> If you really want to keep the array thing at least you should use
> kmemdup(). I'd argue that the overhead won't be huge even if you don't,
> since as you said yourself you don't expect tons of targets (and if you
> do have tons of targets, this approach breaks down anyway).
Ok, I will change kmalloc()/memcpy() by kmemdup().
>> @@ -298,7 +353,10 @@ int nfc_register_device(struct nfc_dev *dev)
>> rc = device_add(&dev->dev);
>> mutex_unlock(&nfc_devlist_mutex);
>>
>> - return rc;
>> + if (rc < 0)
>> + return rc;
>> +
>> + return nfc_genl_device_added(dev);
>
> No rollback if nfc_genl_device_added() fails? Either you need to ignore
> the error or roll back I think.
>
>> +int nfc_genl_device_added(struct nfc_dev *dev)
>> +{
>> + struct sk_buff *msg;
>> + void *hdr;
>> +
>> + pr_debug("%s\n", __func__);
>> +
>> + msg = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
>> + if (!msg)
>> + return -ENOMEM;
>
> I'd probably ignore the errors since any error just means userspace
> wasn't notified, but it can still later look up the devices.
Yes, you're right. I'll fix that.
Aloisio
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
