Search Linux Wireless

Re: [PATCH 2/2] mac80211: Fixing Races for skipping tailroom reservation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2011-06-21 at 19:40 +0530, Yogesh Ashok Powar wrote:

> @@ -455,6 +496,8 @@ int ieee80211_key_link(struct ieee80211_key *key,
>  	__ieee80211_key_replace(sdata, sta, pairwise, old_key, key);
>  	__ieee80211_key_destroy(old_key);
>  
> +	increment_tailroom_need_count(key->local);
> +

This doesn't seem right -- it links the key in first and then does the
update, the mechanism I described relies on doing it the other way
around.

> @@ -498,8 +541,12 @@ void ieee80211_enable_keys(struct ieee80211_sub_if_data *sdata)
>  
>  	mutex_lock(&sdata->local->key_mtx);
>  
> -	list_for_each_entry(key, &sdata->key_list, list)
> +	sdata->local->crypto_tx_tailroom_needed_cnt = 0;
> +

That doesn't seem right either -- only if you have a single sdata that
will work, I think?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux